Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm/wasi] WBT: Avoid workload integrity checks on helix #95941

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

radical
Copy link
Member

@radical radical commented Dec 13, 2023

The first test in WBT run on windows can some times timeout because dotnet runs a workload integrity check before the build, adding to the time taken by the project.

At install time on the build machine, we run dotnet workload list which should do the first use checks, but IIUC, the sentinel is checked in user profile directory, and thus is dependent on the helix machine. Instead, avoid that on helix.

  • [wasm/wasi] sendtohelix-*.targets: move common BuildWasmApps bits to sendtohelix-wasm.targets
  • [wasm/wasi] helix.targets: add DOTNET_SKIP_WORKLOAD_INTEGRITY_CHECK=1 and DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1 for wbt

Fixes #94821 .

@radical radical added the arch-wasm WebAssembly architecture label Dec 13, 2023
@ghost
Copy link

ghost commented Dec 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm/wasi] sendtohelix-*.targets: move common BuildWasmApps bits to sendtohelix-wasm.targets
  • [wasm/wasi] helix.targets: add DOTNET_SKIP_WORKLOAD_INTEGRITY_CHECK=1 and DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1 for wbt

TODO:

  • maybe run this at install time?
Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@ghost ghost assigned radical Dec 13, 2023
@radical radical marked this pull request as ready for review December 13, 2023 04:55
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"instead run this on build machine itself" in this PR we don't force this step. Is the check already switched on, on the build machines, so that no changes are required?

@radical
Copy link
Member Author

radical commented Dec 13, 2023

"instead run this on build machine itself" in this PR we don't force this step. Is the check already switched on, on the build machines, so that no changes are required?

I have updated the test. We are not doing that in this PR. I need to check how we could trigger the workload integrity check for sure, as it depends on the sentinel file too which is in user config directory.

@radical radical merged commit 6b6b040 into dotnet:main Dec 13, 2023
33 checks passed
@radical radical deleted the wbt-first-use branch December 13, 2023 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations times out
2 participants