Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestsManifestGeneration.Etw.cs #97258

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Update TestsManifestGeneration.Etw.cs #97258

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ad4073
Update TestsManifestGeneration.Etw.cs
AaronRobinsonMSFT Jan 21, 2024
08eca5e
Apply suggestions from code review
AaronRobinsonMSFT Jan 21, 2024
7c6d6bc
Apply suggestions from code review
AaronRobinsonMSFT Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public partial class TestsManifestGeneration
/// ETW only works with elevated process
[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/97255", typeof(PlatformDetection), nameof(PlatformDetection.Is32BitProcess))]
AaronRobinsonMSFT marked this conversation as resolved.
Show resolved Hide resolved
public void Test_EventSource_EtwManifestGeneration()
{
var pid = Process.GetCurrentProcess().Id;
Expand Down Expand Up @@ -71,6 +72,7 @@ public void Test_EventSource_EtwManifestGeneration()

[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/97255", typeof(PlatformDetection), nameof(PlatformDetection.Is32BitProcess))]
AaronRobinsonMSFT marked this conversation as resolved.
Show resolved Hide resolved
public void Test_EventSource_EtwManifestGenerationRollover()
{
var pid = Process.GetCurrentProcess().Id;
Expand Down
Loading