-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILCompiler: support publishing using a non-portable ILCompiler build. #99148
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsContributes to dotnet/source-build#1215. @jkotas @hoyosjs @jkoritzinsky @agocke ptal. cc @MichaelSimons @ashnaga @omajid
|
I validated this change together with dotnet/installer#18835. We should let the installer PR flow into the vmr before we merge this one. |
src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props
Outdated
Show resolved
Hide resolved
src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props
Show resolved
Hide resolved
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj
Outdated
Show resolved
Hide resolved
@jkotas I took a look at what is in the non-portable compiler package and compared it with nuget.org's linux-x64 of .NET 9 preview1:
Is the difference in size of the libclrjit files expected? Because we want to enable publishing for the host os+architecture (using the non-portable rid), maybe we can remove some files from the non-portable nuget package that are meant for cross-targeting. |
Looks like the
We include all cross-compiling JITs in both NAOT and R2R compiler packages to keep things simple. If you would like to strip cross-compilation support for non-portable builds, I do not see a problem with it. |
Yes, that is the reason! keepnativesymbols is the default behavior for source-build: Line 385 in 3ddaeae
and from reading #39203 I learn it is the responsibility of the distro package system to strip them.
I'll look closer into it once we have something working from the vmr. |
@jkotas is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me otherwise!
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thank you, @jkotas! |
Contributes to dotnet/source-build#1215.
Closes #66859.
@jkotas @hoyosjs @jkoritzinsky @agocke ptal.
cc @MichaelSimons @ashnaga @omajid