Change the CryptoKit interop entrypoints to use the Swift calling convention #99970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vention This does not change the APIs yet, as we need Swift struct lowering support in Mono before we can switch to using more structured Swift types. This PR switches the entry-points on the C side to use non-method symbols as we'll lose the ability to represent the Swift signatures well in C as we move to a more Swift-friendly API surface (until we are able to remove the native PAL API surface)
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
…ress-of operation explicit in the DllImportEntry macro.
…ll is added to Mono) instead of using DllImportEntry, which now takes an address
jkoritzinsky
requested review from
vargaz,
lambdageek and
thaystg
as code owners
jkoritzinsky
requested review from
kotlarmilos and
agocke
and removed request for
vargaz,
lambdageek and
thaystg
kotlarmilos
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
lambdageek
reviewed
Mar 20, 2024
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
|
/ba-g The unrecognized failure is #99142, which was closed as a fix was made after this PR started running CI |
This was referenced Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change the APIs yet, as we need Swift struct lowering support in Mono before we can switch to using more structured Swift types.
This PR switches the entry-points on the C side to use non-method symbols as we'll lose the ability to represent the Swift signatures well in C as we move to a more Swift-friendly API surface (until we are able to remove the native PAL API surface)