Identify riscv64 as valid arch #37994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
This and dotnet/installer#18247 are enabler PRs to resolve chicken-egg for R2R-on-new-arch. The results would be observed when these are picked up by the runtime via SDK update and dotnet/runtime#96941 is reexamined with cross-build. If these look harmless, please merge. Thanks! :) |
akoeplinger
reviewed
Jan 16, 2024
src/Containers/Microsoft.NET.Build.Containers/Registry/Registry.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RuntimeIdentifierInference.targets
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Jan 16, 2024
…y.cs Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
|
@akoeplinger, does this looks good for merging? |
akoeplinger
reviewed
Jan 19, 2024
| @@ -82,6 +82,9 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <PropertyGroup Condition=" '$(_PlatformWithoutConfigurationInference)' == 'arm64' "> | |||
| <PlatformTarget Condition=" '$(PlatformTarget)' == '' ">arm64</PlatformTarget> | |||
| </PropertyGroup> | |||
| <PropertyGroup Condition=" '$(_PlatformWithoutConfigurationInference)' == 'riscv64' "> | |||
| <PlatformTarget Condition=" '$(PlatformTarget)' == '' ">riscv64</PlatformTarget> | |||
| </PropertyGroup> | |||
There was a problem hiding this comment.
I'd remove the PlatformTarget here too.
akoeplinger
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable riscv64's R2R bring-up in SDK.