Categorize crash as TCP problem when connection never happens #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Feb 27, 2023
steveisok
approved these changes
Feb 27, 2023
premun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCP message, that we use to tell if TCP connection is to blame, can be faulty but once it connects, it's actually usually OK and the crash is an actual crash. This means we only have to categorize the result if the app never connects. It can still happen the app crashes and never connects and then we are not able to tell anyway.
The underlying issue with the TCP connection is still a problem somewhere in mlaunch and the real fix would have to come there but this PR improves categorization after #987 was introduced.
dotnet/arcade#11683