Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change license to MIT #494

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Change license to MIT #494

merged 6 commits into from
Jan 5, 2024

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Dec 31, 2023

No description provided.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7022f0) 82.64% compared to head (9573375) 82.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   82.64%   82.71%   +0.07%     
==========================================
  Files          51       51              
  Lines        2823     2823              
  Branches      312      312              
==========================================
+ Hits         2333     2335       +2     
+ Misses        366      365       -1     
+ Partials      124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayoub5
Copy link
Collaborator Author

kayoub5 commented Jan 3, 2024

@chmorgan could you review this? the coverage change seems to be sporadic due to https://github.com/dotpcap/sharppcap/blob/master/SharpPcap/WinDivert/WinDivertDevice.cs#L140-L154 block having the lines covered change depending on packet count/buffer size.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview of this looks good to me. Did you generate this by hand or some application that went through git history to update it?

@chmorgan
Copy link
Collaborator

chmorgan commented Jan 4, 2024

@kayoub5 oh and no idea on the coverage issue. Surprised we'd get different results on different runs but maybe we have some tests that use random data without using a fixed random number seed.

@kayoub5
Copy link
Collaborator Author

kayoub5 commented Jan 5, 2024

Overview of this looks good to me. Did you generate this by hand or some application that went through git history to update it?

For license I used a reuse-tool to inject the MIT header.
For copyright I checked files history manually, then used reuse-tool to make sure no file is missing copyright header (even added CI job for it), I didn't double check files that already had a copyright header.

@kayoub5 kayoub5 merged commit e7c4eb8 into master Jan 5, 2024
11 checks passed
@kayoub5 kayoub5 deleted the change_license_mit branch January 5, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants