Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for UNIX socket function #126

Merged
merged 2 commits into from
Jul 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set(CMAKE_MACOSX_RPATH 1)

set (MC_VERSION_MAJOR 1)
set (MC_VERSION_MINOR 4)
set (MC_VERSION_PATCH 4)
set (MC_VERSION_PATCH 5)

set (MC_VERSION ${MC_VERSION_MAJOR}.${MC_VERSION_MINOR})
set (MC_APIVERSION ${MC_VERSION}.${MC_VERSION_PATCH})
Expand Down
2 changes: 1 addition & 1 deletion include/Common.h
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ typedef enum {
} op_code_t;

const char* errCodeToString(err_code_t err);
bool isLocalSocket(const char* host);
bool isUnixSocket(const char* host);
server_string_split_t splitServerString(char* input);

} // namespace mc
Expand Down
4 changes: 2 additions & 2 deletions libmc/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
)

__VERSION__ = "1.4.4"
__version__ = "v1.4.4"
__version__ = "1.4.5"
__author__ = "mckelvin"
__email__ = "mckelvin@users.noreply.github.com"
__date__ = "Sat Jun 1 05:10:05 2024 +0800"
__date__ = "Fri Jun 7 06:16:00 2024 +0800"


class Client(PyClient):
Expand Down
4 changes: 2 additions & 2 deletions src/Common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ const char* errCodeToString(err_code_t err) {
}
}

bool isLocalSocket(const char* host) {
bool isUnixSocket(const char* host) {
// errors on the side of false negatives, allowing syntax expansion;
// starting slash to denote socket paths is from pylibmc
// starting slash syntax is from libmemcached
return host[0] == '/';
}

Expand Down
2 changes: 1 addition & 1 deletion src/Connection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Connection::~Connection() {
int Connection::init(const char* host, uint32_t port, const char* alias) {
snprintf(m_host, sizeof m_host, "%s", host);
m_port = port;
m_unixSocket = isLocalSocket(m_host);
m_unixSocket = isUnixSocket(m_host);
if (alias == NULL) {
m_hasAlias = false;
if (m_unixSocket) {
Expand Down
4 changes: 2 additions & 2 deletions src/version.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package golibmc

const _Version = "v1.4.4"
const _Version = "1.4.5"
const _Author = "mckelvin"
const _Email = "mckelvin@users.noreply.github.com"
const _Date = "Sat Jun 1 05:10:05 2024 +0800"
const _Date = "Fri Jun 7 06:16:00 2024 +0800"

// Version of the package
const Version = _Version
Expand Down
Loading