Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enkimi is now able to be used as a subdirectory in a cmake project, example now copies dependencies into binary directory #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cazadorro
Copy link

enkiMI target is now able to be used independently of the executable target, how also has an alias target, can be used as a subdirectory, added ability to conditionally include build files for executable example, example target now exists as enkimi_example, and now copies its .mca runtime dependency as part of the build process using CMake, allowing it to execute with out user taking into consideration where the source is.

With out these changes, using this project as a library would not have been able to be used as a subdirectory in cmake, and building the example would not have been possible with out the copying of its runtime dependencies.

…target, how also has an alias target, can be used as a subdirectory, added ability to conditionally include build files for executable example, example target now exists as enkimi_example, and now copies its .mca runtime dependency as part of the build process using CMake, allowing it to execute with out user taking into consideration where the source is.
@dougbinks dougbinks self-requested a review December 2, 2021 10:05
@dougbinks dougbinks self-assigned this Dec 2, 2021
@dougbinks
Copy link
Owner

Thanks for the PR, I'll take a look at this soon.

Given enkiMI is only 2 source files with no complex options I'd not considered a cmake project to be of much use other than to be able to quickly build the example.

Since it's useful to you (and so perhaps others) I will look into merging this, but I will make changes as for simple projects I prefer only one cmakelists.txt in the root directory to keep the source and example directories 'clean'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants