completely remove use of eval()

downthemall · May 4, 2010 · c345603 · c345603
1 parent e0db859
commit c345603
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/chrome/content/prefpane.js b/chrome/content/prefpane.js
@@ -67,7 +67,12 @@ var acPlugins = {
 			this._list.removeChild(this._list.firstChild);
 		}
 
-		let p = eval(this._pref.value);
+		let p = [];
+		try {
+			p = this._plugins.nsJSON.decode(this._pref.value);
+		}
+		catch (ex) { /* no op */ }
+
 		if (!(p instanceof Array)) {
 			p = [];
 		}