fio is switched to C++ #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpronin
force-pushed
the
cxx
branch
3 times, most recently
from
a872f8c
to
0637c81
Compare
dpronin
pushed a commit
that referenced
this pull request
Jul 25, 2023
nvme-ns generic character devices currently do not support O_DIRECT flag. Check for fio option for direct flag only if filetype is a block device. t/zbd skip test case #1 for character devices as they don't require direct I/O. Tested-by: Vincent Fu <vincent.fu@samsung.com> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Link: https://lore.kernel.org/r/20220531133155.17493-8-ankit.kumar@samsung.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
dpronin
pushed a commit
that referenced
this pull request
Jul 25, 2023
…N for non-sequential CPU ids
When disabling SMT on some systems, the ID of some available CPU may
be larger than the value of sysconf(_SC_NPROCESSORS_ONLN). Without
this patch, fio complains that the expected CPU ID is invalid. Here's
an example from my server:
$ ./fio --cpus_allowed=14 --ioengine=libaio --direct=1 --name=test --numjobs=1 --blocksize=128k --iodepth=1 --rw=read --filename=/dev/nvme0n1
fio: CPU 14 too large (max=11)
fio: failed parsing cpus_allowed=14
System information:
$ lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
CPU(s): 20
On-line CPU(s) list: 0,2,4,6,8,10,12,14,16-19
Off-line CPU(s) list: 1,3,5,7,9,11,13,15
...
Model name: 12th Gen Intel(R) Core(TM) i7-12700
BIOS Model name: 12th Gen Intel(R) Core(TM) i7-12700
...
$ uname -a
Linux localhost.localdomain 4.18.0-348.el8.x86_64 #1 SMP Tue Oct 19 15:14:17 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/redhat-release
CentOS Linux release 8.5.2111
$ cat /proc/cmdline
BOOT_IMAGE=(hd0,gpt2)/vmlinuz-4.18.0-348.el8.x86_64 root=/dev/mapper/cl-root ro nosmt isolcpus=0,2,4,6,8,10,12,14 crashkernel=auto resume=/dev/mapper/cl-swap rd.lvm.lv=cl/root rd.lvm.lv=cl/swap rhgb quiet
$ cat test.c
#include <stdio.h>
#include <unistd.h>
int main(int argc, char *argv[])
{
printf("_SC_NPROCESSORS_ONLN=%ld _SC_NPROCESSORS_CONF=%ld\n",
sysconf(_SC_NPROCESSORS_ONLN), sysconf(_SC_NPROCESSORS_CONF));
}
$ gcc test.c
$ ./a.out
_SC_NPROCESSORS_ONLN=12 _SC_NPROCESSORS_CONF=20
Signed-off-by: mayuanpeng <mayuanpeng@dapustor.com>
dpronin
force-pushed
the
cxx
branch
19 times, most recently
from
2c04894
to
ff3aa5e
Compare
dpronin
force-pushed
the
cxx
branch
10 times, most recently
from
2bf56be
to
7dd5da8
Compare
cmake is a convenient and modern tool and generator to convert cmake-like commands to commands of another build system this commit adds an opportunity for those, whom are fond of cmake, to use the tool within fio project Signed-off-by: Denis Pronin <dannftk@yandex.ru>
- ignore by git index sublime specific files - added .cache to .gitignore (LSP cache generation) Signed-off-by: Denis Pronin <dannftk@yandex.ru>
dpronin
force-pushed
the
cxx
branch
2 times, most recently
from
de8cd14
to
16bf132
Compare
Signed-off-by: Denis Pronin <Pronin.D@raidix.com>
Signed-off-by: Denis Pronin <Pronin.D@raidix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.