Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GC] Add IO related size policy for Parallel GC #662

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

weixlu
Copy link
Collaborator

@weixlu weixlu commented Jul 31, 2024

Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high.

Testing: jtreg

Reviewers: maoliang.ml, yude.lyd

Issue: #661

CR: #662

Summary: add new parallel gc option UseIOPrioritySizePolicy to early shrink heap when io wait is high.

Testing: jtreg

Reviewers: maoliang.ml, yude.lyd

Issue: #661

CR: #662
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024

CLA assistant check
All committers have signed the CLA.

@weixlu
Copy link
Collaborator Author

weixlu commented Aug 1, 2024

This is almost a clean cherry-pick from dragonwell11 https://github.com/dragonwell-project/dragonwell11/pull/847, except the following differences:

  1. log format. change log_debug() to if (PrintAdaptiveSizePolicy) { gclog_or_tty->print_cr(""); } and log_warning() to warning().
  2. In jdk11 we need to modify function should_update_eden_stats() to update eden size upon GC locker caused young gc. In jdk8, we don't need to change anything, since by default eden size will be updated upon GC locker caused young gc.

@weixlu
Copy link
Collaborator Author

weixlu commented Aug 1, 2024

Regarding benchmark score improvement on Spark, we observed a similar acceleration on dw8 as it does on dw11.

@weixlu weixlu requested a review from linade August 1, 2024 02:35
Copy link
Collaborator

@linade linade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, similar to the 11 change

Copy link
Contributor

@mmyxym mmyxym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weixlu weixlu merged commit a400bd2 into master Aug 2, 2024
20 checks passed
@weixlu weixlu deleted the decrease_heap_policy branch August 5, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants