Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JFR] Test jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java crash #691

Merged

Conversation

lingjun-cg
Copy link
Collaborator

@lingjun-cg lingjun-cg commented Oct 31, 2024

Summary: The format of snprintf expect a string, but pass an integer value in function create_emergency_chunk_path which defined in file jfrEmergencyDump.cpp.

Testing: jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java

Reviewers: sendaoYan, D-D-H

Issue: #690

@lingjun-cg lingjun-cg requested review from sendaoYan and D-D-H October 31, 2024 02:09
…Scavenge.java crash

Summary: The format of snprintf expect a string, but pass an integer value in function create_emergency_chunk_path which defined in file jfrEmergencyDump.cpp.

Testing: jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java

Reviewers: sendaoYan, D-D-H

Issue: dragonwell-project#690
@lingjun-cg lingjun-cg force-pushed the bug-jfr-vsnprintfcrash branch from d927e56 to a497032 Compare October 31, 2024 02:12
Copy link
Collaborator

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

ajdk8+该PR patch release二进制运行该用例50w次,均未复现该问题
ajdk8+该PR patch fastdebug二进制运行该用例50w次,均未复现该问题
image
备注:出现了一次java.lang.ArrayStoreException: com.sun.tools.javac.util.SharedNameTable$NameImpl javac异常,应该跟这个PR没有关系

上游jdk8u-dev+该PR patch release二进制运行该用例50w次,均未复现该问题
上游jdk8u-dev+该PR patch fastdebug二进制运行该用例50w次,均未复现该问题
image

TIPS:上述截图,每个job运行该用例5w次

Copy link
Collaborator

@D-D-H D-D-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

@lingjun-cg lingjun-cg merged commit 7cc9690 into dragonwell-project:master Oct 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants