feat: support for rtl and farsi i18n #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParsaArvanehPA
requested review from
jikkai,
Jocs,
ybzky,
yuhongz,
Gggpound,
DR-Univer,
Dushusir,
siam-ese and
wzhudev
as code owners
View Deployment
|
ParsaArvanehPA
changed the title
ParsaArvanehPA
changed the title
jikkai
reviewed
Sep 24, 2024
|
@jikkai |
jikkai
force-pushed
the
feature/add-support-for-rtl-and-farsi-i18n
branch
from
1af04d3
to
f97016d
Compare
|
/update-snapshots |
jikkai
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for RTLIn the main.ts of the sheets module, change the
localetofa_IR.The process of changing the direction of html is automaticlly handled based on the language passes to
localein main.ts.Please see these:
changin html dir base on localelocales that are rtl should be defined here🔶Notes:
There is still some work that needs to be done to fully support RTL; they are all css related. I will try to fix those in other PRs, since this PR is moslty about adding farsi i18n.
Pull Request Checklist