fix(sheets-hyper-link): hyper-link operator issues #3628

weird94 · 2024-09-28T17:28:13Z

close https://github.com/dream-num/univer-pro/issues/2708
close https://github.com/dream-num/univer-pro/issues/2719
close https://github.com/dream-num/univer-pro/issues/2631
close https://github.com/dream-num/univer-pro/issues/2691
close https://github.com/dream-num/univer-pro/issues/2504

Pull Request Checklist

Related tickets or issues have been linked in the PR description (or missing issue).
Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
Unit tests have been added for the changes (if applicable).
Breaking changes have been documented (or no breaking changes introduced in this PR).

github-actions · 2024-09-28T17:28:53Z

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

github-actions · 2024-09-28T17:32:25Z

Playwright test results

2 failed
9 passed

Details

11 tests across 5 suites
3 minutes, 55 seconds
37facab
For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content
chromium › visual-comparison/sheet/sheets-visual-comparison.spec.ts › diff demo sheet content

codecov · 2024-09-28T17:44:26Z

Codecov Report

Attention: Patch coverage is 1.56250% with 63 lines in your changes missing coverage. Please review.

Project coverage is 31.80%. Comparing base (71229b3) to head (37facab).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...docs/data-model/text-x/build-utils/text-x-utils.ts	0.00%	16 Missing ⚠️
packages/sheets-ui/src/common/utils.ts	0.00%	11 Missing ⚠️
...ui/src/components/range-selector/RangeSelector.tsx	0.00%	9 Missing ⚠️
packages/design/src/components/popup/RectPopup.tsx	0.00%	8 Missing ⚠️
...ets-hyper-link-ui/src/views/CellLinkEdit/index.tsx	0.00%	7 Missing ⚠️
...re/src/docs/data-model/text-x/build-utils/parse.ts	20.00%	4 Missing ⚠️
...ackages/docs-ui/src/basics/custom-range-factory.ts	0.00%	4 Missing ⚠️
...sheets-hyper-link-ui/src/services/popup.service.ts	0.00%	2 Missing ⚠️
...services/selection/doc-selection-render.service.ts	0.00%	1 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3628      +/-   ##
==========================================
- Coverage   31.81%   31.80%   -0.02%     
==========================================
  Files        2225     2225              
  Lines      115601   115648      +47     
  Branches    25447    25462      +15     
==========================================
+ Hits        36776    36777       +1     
- Misses      78825    78871      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oumomomo · 2024-09-29T02:49:44Z

https://github.com/dream-num/univer-pro/issues/2719

1、选中链接点击取消链接，左键点击其他单元格时面板不消失
2024_9_29 10_46_41 video.webm

2、选中链接点击取消链接，使用快捷键crtl+B，加粗不生效
2024_9_29 16_28_28 video.webm

univer-bot · 2024-09-29T02:49:47Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2719

Select a link and click to cancel the link. The panel will not disappear when you left-click on other cells.
2024_9_29 10_46_41 video.webm
Select the link, click to cancel the link, and use the shortcut key crtl+B. Bold will not take effect.
2024_9_29 16_28_28 video.webm

weird94 · 2024-09-29T03:49:22Z

dream-num/univer-pro#2719 选中单元格点击添加链接，左键点击其他单元格时面板不消失 2024_9_29 10_46_41 video.webm

fixed

univer-bot · 2024-09-29T03:49:26Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

dream-num/univer-pro#2719 Select a cell and click Add Link. The panel does not disappear when you left-click on other cells. 2024_9_29 10_46_41 video.webm

fixed

oumomomo · 2024-09-29T07:54:19Z

https://github.com/dream-num/univer-pro/issues/2504
在文档内取消链接后使用上下左右键，光标移动的位置不对
操作步骤：
1、在文档内添加链接
2、将光标移动到链接最后方
3、取消超链接后使用上下左右键

univer-bot · 2024-09-29T07:54:23Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

https://github.com/dream-num/univer-pro/issues/2504
After canceling the link in the document, the cursor moves to the wrong position when using the up, down, left and right keys.
Operation steps:

Add a link to the document
Move the cursor to the end of the link
Use the up, down, left and right keys after canceling the hyperlink.

…elector

weird94 · 2024-10-08T07:30:09Z

dream-num/univer-pro#2504 在文档内取消链接后使用上下左右键，光标移动的位置不对操作步骤： 1、在文档内添加链接 2、将光标移动到链接最后方 3、取消超链接后使用上下左右键

fixed

univer-bot · 2024-10-08T07:30:13Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

dream-num/univer-pro#2504 When using the up, down, left and right keys after canceling the link in the document, the cursor moves to the wrong position. Steps: 1. Add a link in the document 2. Move the cursor to the end of the link 3. Use the up, down, left and right keys after canceling the hyperlink![image](https://private-user-images.githubusercontent.com/167171356/371836427 -99f7bbbe-a236-4468-8363-295f826201f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb2 50ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjgzNzAyNDcsIm5iZiI6MTcyODM2OTk0N ywicGF0aCI6Ii8xNjcxNzEzNTYvMzcxODM2NDI3LTk5ZjdiYmJlLWEyMzYtNDQ2OC04MzYzLTI5 NWY4MjYyMDFmMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQxMDA4JTJGdXMtZWFzdC0xJ TJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MTAwOFQwNjQ1NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMGE0NTlhNjI4MGEyZWNmMDg1MDAxNzEzM zZhZjdjNDc1YTQ2N2RkNjE2MWVhMDhiYjM2YzZiYWQ4M2RkMjc2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.v5b8DyNCUALKIRbl_WCQjrKYObv8Sw0rFwWgSbOFK3E)

fixed

…elector

weird94 · 2024-10-08T08:02:11Z

/update-snapshots

weird94 · 2024-10-08T09:07:21Z

/update-snapshots

weird94 · 2024-10-08T09:08:04Z

/update-snapshots

weird94 · 2024-10-08T09:08:14Z

/update-snapshots

fix: hyper-link range-selector

effc952

weird94 requested review from jikkai and Jocs as code owners September 28, 2024 17:28

weird94 added 3 commits September 29, 2024 01:29

feat: update

0b73290

feat: update

7aab74e

feat: update

eca7284

univer-bot bot added the qa:untested This PR is ready to be tested label Sep 28, 2024

feat: update

e076bbd

weird94 added 2 commits September 29, 2024 01:47

feat: update

4f7b384

feat: update

f59d334

weird94 requested a review from wzhudev as a code owner September 28, 2024 18:01

weird94 added 2 commits September 29, 2024 02:09

feat: update

76756c1

fix: update

d9dfb2c

oumomomo added the qa:rejected label Sep 29, 2024

univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 29, 2024

weird94 added 2 commits September 29, 2024 11:36

feat: update

c5cb64e

fix: update

96c9892

weird94 added qa:untested This PR is ready to be tested and removed qa:rejected labels Sep 29, 2024

oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 29, 2024

univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 29, 2024

feat: update

93f21e4

Jocs approved these changes Sep 29, 2024

View reviewed changes

weird94 added 2 commits September 29, 2024 15:19

fix: add line on empty cell with paragraph

5179a7d

fix: dream-num/univer-pro#2504

8373152

weird94 changed the title ~~fix(sheets-hyper-link): hyper-link range-selector~~ fix(sheets-hyper-link): hyper-link operator issues Sep 29, 2024

oumomomo added qa:rejected and removed qa:verified This PR has already by verified by a QA and is considered good enough to be merge labels Sep 29, 2024

Merge remote-tracking branch 'origin/dev' into fix/hyper-link-range-s…

79bc52f

…elector

weird94 requested review from ybzky, yuhongz, Dushusir and lumixraku as code owners September 29, 2024 14:03

feat: update

6469643

weird94 added qa:untested This PR is ready to be tested and removed qa:rejected labels Oct 8, 2024

weird94 added 2 commits October 8, 2024 15:38

Merge remote-tracking branch 'origin/dev' into fix/hyper-link-range-s…

098bf10

…elector

feat: update

37facab

weird94 removed the qa:untested This PR is ready to be tested label Oct 8, 2024

weird94 merged commit e27bf5e into dev Oct 8, 2024
8 of 9 checks passed

weird94 deleted the fix/hyper-link-range-selector branch October 8, 2024 09:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sheets-hyper-link): hyper-link operator issues #3628

fix(sheets-hyper-link): hyper-link operator issues #3628

weird94 commented Sep 28, 2024 •

edited

Loading

github-actions bot commented Sep 28, 2024 •

edited

Loading

github-actions bot commented Sep 28, 2024 •

edited

Loading

codecov bot commented Sep 28, 2024 •

edited

Loading

oumomomo commented Sep 29, 2024 •

edited

Loading

univer-bot bot commented Sep 29, 2024 •

edited

Loading

weird94 commented Sep 29, 2024

univer-bot bot commented Sep 29, 2024

oumomomo commented Sep 29, 2024

univer-bot bot commented Sep 29, 2024

weird94 commented Oct 8, 2024

univer-bot bot commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

fix(sheets-hyper-link): hyper-link operator issues #3628

fix(sheets-hyper-link): hyper-link operator issues #3628

Conversation

weird94 commented Sep 28, 2024 • edited Loading

Pull Request Checklist

github-actions bot commented Sep 28, 2024 • edited Loading

View Deployment

github-actions bot commented Sep 28, 2024 • edited Loading

Playwright test results

Details

codecov bot commented Sep 28, 2024 • edited Loading

Codecov Report

oumomomo commented Sep 29, 2024 • edited Loading

univer-bot bot commented Sep 29, 2024 • edited Loading

weird94 commented Sep 29, 2024

univer-bot bot commented Sep 29, 2024

oumomomo commented Sep 29, 2024

univer-bot bot commented Sep 29, 2024

weird94 commented Oct 8, 2024

univer-bot bot commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Oct 8, 2024

weird94 commented Sep 28, 2024 •

edited

Loading

github-actions bot commented Sep 28, 2024 •

edited

Loading

github-actions bot commented Sep 28, 2024 •

edited

Loading

codecov bot commented Sep 28, 2024 •

edited

Loading

oumomomo commented Sep 29, 2024 •

edited

Loading

univer-bot bot commented Sep 29, 2024 •

edited

Loading