Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: render in viewrange not all model #3637

Merged
merged 6 commits into from
Oct 9, 2024
Merged

perf: render in viewrange not all model #3637

merged 6 commits into from
Oct 9, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 29, 2024

close https://github.com/dream-num/univer-pro/issues/2716

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 29, 2024

Playwright test results

passed  11 passed

Details

stats  11 tests across 5 suites
duration  2 minutes, 50 seconds
commit  e13665e
info  For more information, see full report

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 293 lines in your changes missing coverage. Please review.

Project coverage is 31.78%. Comparing base (7a0b3ed) to head (e13665e).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ne-render/src/components/sheets/extensions/font.ts 0.00% 86 Missing ⚠️
packages/engine-render/src/basics/draw.ts 0.00% 69 Missing ⚠️
...-render/src/components/sheets/extensions/border.ts 0.00% 48 Missing ⚠️
...der/src/components/sheets/extensions/background.ts 0.00% 40 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 28 Missing ⚠️
...ne-render/src/components/docs/extensions/border.ts 0.00% 6 Missing ⚠️
packages/engine-render/src/context.ts 0.00% 6 Missing ⚠️
...s/engine-render/src/components/sheets/constants.ts 0.00% 5 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 4 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3637      +/-   ##
==========================================
- Coverage   31.80%   31.78%   -0.02%     
==========================================
  Files        2225     2226       +1     
  Lines      115648   115693      +45     
  Branches    25462    25461       -1     
==========================================
  Hits        36777    36777              
- Misses      78871    78916      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer
Copy link
Collaborator

image
这个报告 能不能算一个fps或者frame耗时的平均值,直接显示出来。不用点击里面一个个的看

@univer-bot
Copy link

univer-bot bot commented Sep 30, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

image
Can this report calculate the average fps or frame time and display it directly? No need to click inside to see each one

@lumixraku lumixraku force-pushed the perf/switch-matrix2 branch 5 times, most recently from 5e229d4 to ce068bb Compare October 8, 2024 08:21
export const BG_Z_INDEX = 21;
export const PRINTING_BG_Z_INDEX = 21;

export const EXPAND_SIZE_FOR_RENDER_OVERFLOW = 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we provide a function or poperty fot user to customize the overfollow testing scope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customize in facade?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to config service.

@lumixraku lumixraku force-pushed the perf/switch-matrix2 branch 3 times, most recently from 939561e to d56400d Compare October 8, 2024 12:36
@lumixraku lumixraku changed the title perf: switch matrix2 perf: render in viewrange not all model Oct 8, 2024
@lumixraku lumixraku marked this pull request as ready for review October 8, 2024 12:48
@lumixraku lumixraku force-pushed the perf/switch-matrix2 branch 2 times, most recently from 028a774 to 214c523 Compare October 8, 2024 13:09
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Oct 9, 2024
@lumixraku lumixraku removed the qa:untested This PR is ready to be tested label Oct 9, 2024
@lumixraku lumixraku merged commit 7b1462b into dev Oct 9, 2024
9 checks passed
@lumixraku lumixraku deleted the perf/switch-matrix2 branch October 9, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants