Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): header footer setting not focus #3698

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 10, 2024

close https://github.com/dream-num/univer-pro/issues/2782

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 10, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 8 seconds
commit  d1c2d70
info  For more information, see full report

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 30.95%. Comparing base (8a48479) to head (d1c2d70).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ews/header-footer/panel/DocHeaderFooterOptions.tsx 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3698      +/-   ##
==========================================
- Coverage   30.96%   30.95%   -0.01%     
==========================================
  Files        2286     2286              
  Lines      118603   118629      +26     
  Branches    26130    26146      +16     
==========================================
+ Hits        36725    36727       +2     
- Misses      81878    81902      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review October 11, 2024 11:53
@Jocs Jocs requested a review from jikkai as a code owner October 11, 2024 11:53
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 11, 2024
@oumomomo
Copy link

操作步骤:
1、勾选首页不同后输入内容
2、再勾选奇偶页不同输入内容
3、取消勾选奇偶页不同并输入内容

实际结果:直接编辑不生效,需要手动点击页眉页脚才可以继续编辑
2024_10_12 11_54_58 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 12, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Operation steps:

  1. Check the home page and enter the content.
  2. Then check the different input contents on the odd and even pages.
  3. Uncheck Odd and even pages are different and enter the content

Actual result: Direct editing does not take effect. You need to manually click on the header and footer to continue editing.
2024_10_12 11_54_58 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 12, 2024
@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Oct 16, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 17, 2024
@Jocs
Copy link
Contributor Author

Jocs commented Oct 17, 2024

/update-snapshots

@Jocs Jocs merged commit 2db351b into dev Oct 17, 2024
10 checks passed
@Jocs Jocs deleted the fix/header-footer-setting branch October 17, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants