Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Medal Achievement Time #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✨ Medal Achievement Time #21

wants to merge 2 commits into from

Conversation

dsperac
Copy link

@dsperac dsperac commented Apr 28, 2023 •
edited
Loading

User facing

  • medal achievement time tracking
  • new settings tab and accompanying settings for displaying medal times in the main tracker ui
  • new setting for showing fractions of second (and added a description to the thousandth digit setting)
  • recap ui shows medal times with headers showing completion percentage
  • made the opacity of the recap ui a bit less transparent for better readability
  • moved 'Last Played' column to last position for all games
  • fixed bug where respawn related settings weren't working correctly

Internals

  • moved settings to a separate file
  • extracted colors as constants to a separate file
  • removed duplicated folder_location definitions, moved to root file and logic for checking/creating folder to main()
  • some code quality polish (whitespaces, etc)

dsperac added 2 commits April 28, 2023 10:08
@dsperac
✨ Medal Achievement Time (#1)
49818f0 
* Storing and displaying medal achievement time

* added setting to show fractions of second, moved settings to separate file

* refactoring and settings update

* refactoring

renamed medalname_time variables to time_to_medalname so it's not confused with the map medal times

* fixed unnecessary code execution

* dont write medal times to file if not tmnext (for now)

* moved duplicate folder location definition and creation logic to entry

* fixed respawn component display

* Added medal times to recap, various refactoring and tweaks

* Implemented logic to lock medals if untracked pb exists

* still need to pull actual pb time

* implemented pb time loading

* changed locked medal display

* refactoring

* fixed sync pb loading

* quickfix

* Implemented proper recap ui for each map

* plus various refactoring and tweaks

* Implemented recap medal totals

+ recap ui styling

* recap ui tweaks

* better display and sorting

* increased opacity for recap ui, refactoring, added todo for detecting finish time when playing on remote maps

* refactoring

* refactoring

* refactoring, extracted colors to constants
@dsperac
refactoring
acbcb68
@dsperac dsperac changed the title ✨ Medal Achievement Time (#1) ✨ Medal Achievement Time Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsperac