Fully refactored application to correctly use git wrapper.

drevops · Dec 9, 2024 · 1356b44 · 1356b44
1 parent 2a7f68b
commit 1356b44
Show file tree

Hide file tree

Showing 30 changed files with 1,734 additions and 2,756 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -5,7 +5,7 @@ aliases:
   - &container_config
     working_directory: /workspace/code
     docker:
-      - image: drevops/ci-runner:24.4.0
+      - image: drevops/ci-runner:24.11.0
         environment:
           COMPOSER_ALLOW_SUPERUSER: 1
           DEPLOY_SSH_FINGERPRINT: *deploy_ssh_fingerprint

diff --git a/composer.json b/composer.json
@@ -62,15 +62,15 @@
         ],
         "lint": [
             "phpcs",
-            "phpmd --exclude vendor,vendor-bin,node_modules . text phpmd.xml",
             "phpstan --memory-limit=-1",
+            "phpmd --exclude vendor,vendor-bin,node_modules,TokenTest.php . text phpmd.xml",
             "rector --clear-cache --dry-run"
         ],
         "lint-fix": [
             "rector --clear-cache",
             "phpcbf"
         ],
         "reset": "rm -rf vendor vendor-bin composer.lock",
-        "test": "if [ \"${XDEBUG_MODE}\" = 'coverage' ]; then phpunit; else phpunit --no-coverage; fi"
+        "test": "phpunit"
     }
 }
diff --git a/phpcs.xml b/phpcs.xml
@@ -23,6 +23,12 @@
         <exclude-pattern>*.test</exclude-pattern>
     </rule>
 
+    <!-- Allow missing class comments in tests. -->
+    <rule ref="Drupal.Commenting.ClassComment.Missing">
+        <exclude-pattern>*.Test\.php</exclude-pattern>
+        <exclude-pattern>*.TestCase\.php</exclude-pattern>
+        <exclude-pattern>*.test</exclude-pattern>
+    </rule>
     <!-- Allow missing function comments in tests. -->
     <rule ref="Drupal.Commenting.FunctionComment.Missing">
         <exclude-pattern>*.Test\.php</exclude-pattern>

diff --git a/rector.php b/rector.php
@@ -14,6 +14,7 @@
 
 use Rector\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector;
 use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector;
+use Rector\CodingStyle\Rector\Catch_\CatchExceptionNameMatchingTypeRector;
 use Rector\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector;
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector;
@@ -41,6 +42,7 @@
 
   $rectorConfig->skip([
     // Rules added by Rector's rule sets.
+    CatchExceptionNameMatchingTypeRector::class,
     CountArrayToEmptyArrayComparisonRector::class,
     DisallowedEmptyRuleFixerRector::class,
     InlineArrayReturnAssignRector::class,