KG-4574: Allow replacing edges for faster diff manipulation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishs
approved these changes
Nov 2, 2024
src/diff.rs
Outdated
| /// Does not check that the node IDs are valid (i.e. not marked as deleted). | ||
| /// CAUTION: This replaces existing diff edges by the provided ones. | ||
| pub unsafe fn set_edges_unchecked(&mut self, edges: HashMap<Id, HashMap<Id, W>>) { | ||
| let _ = std::mem::replace(&mut self.edges.new_or_updated, edges); |
There was a problem hiding this comment.
What is the difference between
let _ = std::mem::replace(&mut self.a,b);
And
self.a = b;
In the first case we could return the old value but if we don't want to then is there anything else?
There was a problem hiding this comment.
- remove unnecessary std::mem::replace
DGPardo
force-pushed
the
KG-4574-set-edges-method
branch
from
3b2b059 to
06678bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a set edges method for faster edition of the Diff Object.