Publish workflow #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishs
reviewed
May 28, 2024
.github/workflows/publish.yml
Outdated
| push: | ||
| branches: | ||
| - 'main' | ||
| pull_request: |
There was a problem hiding this comment.
Are we sure on pull_request? Would this build and release the pr branch?
There was a problem hiding this comment.
oh good point. Let me remove that
LNS98
commented
May 28, 2024
.github/workflows/publish.yml
Outdated
| release: | ||
| name: Release | ||
| runs-on: ubuntu-latest | ||
| if: "startsWith(github.ref, 'refs/tags/')" |
There was a problem hiding this comment.
@hamishs yes you need to tag here. (In this case I have already uploaded for 0.0.2)
hamishs
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile (for common formats) and publish to PyPI on new version using maturin-actions.