Stop using keychain in integration tests #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianlocke
changed the title
julianlocke
force-pushed
the
test-stop-using-keychain-in-integration-tests
branch
from
acc091c
to
bacab8a
Compare
jaquish
reviewed
Dec 14, 2023
| @@ -144,3 +144,37 @@ public class SecureStorageAccesDefaultImpl: SecureStorageAccess { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public class SecureStorageAccessTestImpl: SecureStorageAccess { | |||
There was a problem hiding this comment.
Shouldn't this live next to test code?
There was a problem hiding this comment.
Fair point, let me poke at this
jaquish
reviewed
Dec 14, 2023
|
|
||
| /// Only for use in tests. Resets DropboxOAuthManager so a new one for Team client use can be set up. | ||
| @objc | ||
| public static func __test_only_resetForTeamSetup() { |
There was a problem hiding this comment.
Same here- shouldn't this live in /TestSwiftyDropbox?
jaquish
approved these changes
Dec 14, 2023
julianlocke
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
groupsUpdatewould collide on a group name. The group was always previously deleted, but trying to recreate it immediately could problematically occur before some cleanup or state propagation.