Merge pull request #453 from drowe67/ms-reporter-highlight-tx

Set background color in FreeDV Reporter to red on TX.
drowe67 · Jun 27, 2023 · bd372e2 · bd372e2
2 parents abae434 + e6638dd
commit bd372e2
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 6 deletions.
diff --git a/USER_MANUAL.html b/USER_MANUAL.html
@@ -616,7 +616,7 @@ <h2 data-number="17.1" id="v1.8.12-tbd-2023"><span class="header-section-number"
 </ul></li>
 <li>Enhancements:
 <ul>
-<li>Add the ability to request that another FreeDV Reporter user QSY. (PR #434)</li>
+<li>Add the ability to request that another FreeDV Reporter user QSY. (PR #434, #453)</li>
 <li>Display ‘Digital’ on button when Analog mode is active. (PR #447)</li>
 <li>Set minimum size for Mode box to 250px. (PR #446)</li>
 <li>Notify FreeDV Reporter if only capable of RX. (PR #449)</li>

diff --git a/USER_MANUAL.md b/USER_MANUAL.md
@@ -874,7 +874,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
     * Fix audio dialog plot display and lockup issues. (PR #450)
     * Disable PTT and Voice Keyer buttons if only RX devices are configured. (PR #449)
 2. Enhancements:
-    * Add the ability to request that another FreeDV Reporter user QSY. (PR #434)
+    * Add the ability to request that another FreeDV Reporter user QSY. (PR #434, #453)
     * Display 'Digital' on button when Analog mode is active. (PR #447)
     * Set minimum size for Mode box to 250px. (PR #446)
     * Notify FreeDV Reporter if only capable of RX. (PR #449)

diff --git a/USER_MANUAL.pdf b/USER_MANUAL.pdf
diff --git a/src/freedv_reporter.cpp b/src/freedv_reporter.cpp
@@ -327,12 +327,11 @@ void FreeDVReporterDialog::onTransmitUpdateFn_(std::string sid, std::string last
                 if (transmitting)
                 {
                     txStatus = "Transmitting";
-                    //nonRedBackground_ = m_listSpots->GetItemBackgroundColour(index);
-                    //m_listSpots->SetItemBackgroundColour(index, *wxRED);
+                    m_listSpots->SetItemBackgroundColour(index, *wxRED);
                 }
                 else
                 {
-                    //m_listSpots->SetItemBackgroundColour(index, nonRedBackground_);
+                    m_listSpots->SetItemBackgroundColour(index, wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOX));
                 }
 
                 m_listSpots->Freeze();

diff --git a/src/freedv_reporter.h b/src/freedv_reporter.h
@@ -70,7 +70,6 @@ class FreeDVReporterDialog : public wxDialog
 
      private:
          FreeDVReporter* reporter_;
-         wxColour nonRedBackground_; // need to save BG since wxNullColour doesn't seem to work
 
          void onReporterConnect_();
          void onReporterDisconnect_();