-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve labeling of PTT/CAT control options. #550
Conversation
When setting up a RX only system there is no 'None' option for 'PTT Uses:' which is very confusing. Maybe that box should be greyed when audio settings for TX are none. |
It would be sensible to have this covered by the enhancement request for #417 multiple reloadable settings. |
I think it might be confusing to gray out that setting if there are no transmit sound devices set. (The user could very well be setting Hamlib settings first, before audio devices.) Also, most people don't need to change that setting, anyway; it's there for the oddball radios that don't have working CAT support for PTT.
The labeling changes in this PR, or did you mean consolidating the config dialogs? |
I was referring to @barjac comments on the issue with Rx only, confusion with config settings etc. If it is possible to create a PR for the #417 enhancement then it would mean only doing the work once. It seemed to me to be sensible to have templates of some kind for this, creating a new config would allow the selection of a Tx/Rx one, or Rx only. Additional templates could be added if needed. I realise that this is quite a big task, the wsjtx Configurations menu has been around a while, maybe something like it would give us a decent UI for this. |
I think if we were to do any consolidation, Easy Setup would likely get rolled into Tools->Options, with the existing PTT and audio device settings still accessible via their respective Advanced buttons. That would still be a lot of work and I'd like to do some refactoring and other cleanup first before attempting. |
Yes, I wasn't suggesting that you should just dive in and hack everything about. Thought required, and you have clearly already done some thinking about it. |
OK understood , so could there be a 'none' option in the list?
Yes but it still needs to make sense by allowing users to select CAT or None for 'PTT Uses:' even if it actually does nothing. :) |
The typical way of setting up a RX only station is to not specify any TX sound devices, but adding None probably won't hurt: #556 |
Not had chance to check fully but selecting 'None' seems to be a switch from transceive to receive only mode without needing to touch the audio settings. |
What about renaming "None" to "None (RX Only)" in that drop-down? But yeah, the user manual could probably be improved in general. not just when talking about this feature. PRs to update it are welcome :) |
Improves labeling of CAT control/Hamlib related options based on feedback in #539: