Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake and code logic to allow compilation without LPCNet. #711

Merged
merged 11 commits into from
Apr 13, 2024

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Apr 13, 2024

This PR adds logic to CMake and the main codebase to permit compilation without LPCNet by doing the following:

  1. Introducing a new LPCNET_DISABLE environment variable for the build_*.sh build scripts. By default, this is set to 0, but when set to 1 will build freedv-gui without LPCNet.
  2. Introducing a BOOTSTRAP_LPCNET CMake variable. This is intended for use when having CMake compile Codec2 for you (versus using the build scripts).
  3. Forcing the "2020 enable" flag to false when LPCNet isn't compiled in, ensuring that the 2020 modes can't be selected by the user.
  4. Fixing minor compiler failures when not using LPCNet.

This effort is being undertaken in preparation for a potential future deprecation of LPCNet and the 2020 modes (date TBD).

@tmiw tmiw merged commit d8ff7e8 into master Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant