Set timeout for Hamlib comms to avoid GUI getting stuck. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this is related but testing with this patch: If FreeDV is run and the modem started without the radio switched on there is oddly no complaint from FreeDV. |
|
I'm honestly not sure how the timeout stuff interacts with Hamlib exactly. What version of the latter are you running? It's possible that there may still need to be kinks worked out depending on the radio you're using (we're currently trying to get the timeout stuff working properly with Icom). |
Current git master @ #8d5256533 using rigctld. I was using an earlier snapshot of hamlib previously from March. |
|
Can you try running |
Ah I see what you mean - without FreeDV in the mix? So using rigctl not rigctld. OK I never use it that way but running the following with the radio off it takes 7 seconds for it to error out: If the radio is on, the connection is immediate and rigctl waits for a command. Notice all the 'Communication timed out' messages, but it soldiers onward and even: 'no response to get_id from rig...continuing anyway' :) With those same extra parameters set in the rigctld.service systemd unit file with the service enabled, launching FreeDV and hitting PTT with the radio turned off, it takes 55 seconds before any error message appears in FreeDV. So no change as far as I can tell. |
|
Yeah, this seems like a Hamlib problem. Maybe @mdblack98 has an idea? It's also possible that I'm misunderstanding the exact meaning of |
|
Notice the message: kenwood_open: no response to get_id from rig...continuing anyway |
Fair enough. I'm not sure how this could be checked for on my side, either, come to think of it. |
OK yes, I did say "It is a rather silly thing to do but probably should not be allowed to happen." however if we can't stop it happening then "don't do that!" is enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #742 by setting a timeout when connecting to the radio via Hamlib. Note that this requires hamlib 4.6~git to have full effect (especially with Icom radios).