Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't increment finished-subforms on comments. #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamFIREcracker
Copy link

Currently, with lispindent taught to have a LIN of 2 for
DEFINE-GUESSER, indenting the following expression:

(cg:define-guesser apt-install
    ;; On Ubuntu, Bash suggests you to `apt install XXX` when the command
    ;; you just run was not found inside PATH.
    ;; This guesser looks looks for that suggestion.
    ("(sudo apt install [^ ]+)" (apt-cmd))
  (format NIL "~a" apt-cmd))

Would produce:

(cg:define-guesser apt-install
    ;; On Ubuntu, Bash suggests you to `apt install XXX` when the command
  ;; you just run was not found inside PATH.
  ;; This guesser looks looks for that suggestion.
  ("(sudo apt install [^ ]+)" (apt-cmd))
  (format NIL "~a" apt-cmd))

Note how only the first comment is properly indented. Well, this commit fixes it.

Currently, with `lispindent` taught to have a LIN of 2 for
`DEFINE-GUESSER`, indenting the following expression:

    (cg:define-guesser apt-install
        ;; On Ubuntu, Bash suggests you to `apt install XXX` when the command
        ;; you just run was not found inside PATH.
        ;; This guesser looks looks for that suggestion.
        ("(sudo apt install [^ ]+)" (apt-cmd))
      (format NIL "~a" apt-cmd))

Would produce:

    (cg:define-guesser apt-install
        ;; On Ubuntu, Bash suggests you to `apt install XXX` when the command
      ;; you just run was not found inside PATH.
      ;; This guesser looks looks for that suggestion.
      ("(sudo apt install [^ ]+)" (apt-cmd))
      (format NIL "~a" apt-cmd))

Note how only the first comment is _properly_ indented.  Well, this
commit fixes it.
@iamFIREcracker
Copy link
Author

@ds26gte - any chances this can be merged, or should I close this instead? I simply wanted to gauge your interest in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant