-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication #24
base: master
Are you sure you want to change the base?
Conversation
-Added Swagger, to allow better visualisation of API(added in requirements.txt file). -Added Authentication app, which allows users to register. -Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘webapp’. - Added all Serializations and Models required to, register verify and login Users -Added Jwt for token generation (added in requirements.txt file) -Two tokens are generated, refresh and access - Added login through Swagger interface, which requires users to input generated token, to access information from the API. -Added Renderers in order to ensure consistent responses in the API, especially when an error is generated.
Can you please rename this request to:
This follows the naming convention for commits |
Also, Git should not be tracking
Then run Once this is done we will not need to worry about these files again. |
@DamiAdesola Impressive work! It will take me some more time to review everything, and it's looking good so far. As a general rule, two separate tasks like adding authentication and visualization should be handled in separate issues/branches/pull requests. But this time it's okay to keep them together because you've already done the work on this branch. |
Thanks, @jbinvnt, I can separate them if you want. Into two different commits and two different branches. |
-Added Swagger, to allow better visualisation of API(added in requirements.txt file). -Added Authentication app, which allows users to register. -Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘webapp’. - Added all Serializations and Models required to, register verify and login Users -Added Jwt for token generation (added in requirements.txt file) -Two tokens are generated, refresh and access - Added login through Swagger interface, which requires users to input generated token, to access information from the API. -Added Renderers in order to ensure consistent responses in the API, especially when an error is generated.
Hi @jbinvnt , I have taken your comment into consideration and separated, Authentication and (Authentication with Swagger) into two separate branches. This branch LMVP-6 does not have the swagger visualisation installed, but the branck LMVP-Swagger has swagger |
I think it would be most efficient to focus on getting this branch ready to merge first, because it directly impacts the frontend tasks. Then we can look at visualization separately. |
Can you please add to the README on this branch, giving instructions for any steps needed with |
Hey, @jbinvnt thanks for the feedback. I will start working on getting that done, with all the information included. |
Hey @jbinvnt, i think in order to make it easier and smoother to collaborate, with the front end team, we use swagger visualisation. This is because while running some test and updating the read I noticed some things would clash with each other. I would be able to also add to the read me how to effectively use the swagger interface. |
@DamiAdesola to clarify, I agree that we should keep your changes that allow Swagger visualization. Just for organization, it would be helpful to have two different pull requests and branches. Let me know what you think of this idea for how to accomplish that without losing any of your work:
|
Hey @jbinvnt ,Thanks for the message. |
So before I do any more work and change anything please have a look at the pull request for LMVP-26, and if you think you will prefer to have it differently then I understand. |
My Changes
-Added Swagger, to allow better visualisation of API(added in requirements.txt file).
-Added Authentication app, which allows users to register.
-Added Email Verification, which sends users verification tokens, which can then be successfully verified on the API (Email used is a test Gmail account. Details are in the setting.py file in ‘webapp’.
-Added Jwt for token generation (added in requirements.txt file)
-Two tokens are generated, refresh and access
-Added Renderers in order to ensure consistent responses in the API, especially when an error is generated.
email:lmvptest@gmail.com
password:lmvptest_user
From there, i have a sample user created for testing purposes , on functions like 'auth/login/'
Example:{
"username": "testuser1",
"email": "user@example.com",
"password": "test1234"
}