update mini notebook image and modify targetport #226
Conversation
PaulineMauryL
force-pushed
the
wip_371_k8s
branch
2 times, most recently
from
b2f2dfc
to
3b8faae
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
PaulineMauryL
force-pushed
the
wip_371_k8s
branch
from
3b8faae
to
e88a711
Compare
| @@ -8,7 +8,7 @@ spec: | |||
| type: {{ .Values.server.service.type }} | |||
| ports: | |||
| - port: {{ .Values.server.service.port}} | |||
| targetPort: http | |||
There was a problem hiding this comment.
i wonder why this works ?
There was a problem hiding this comment.
ah ok, the names 'http' match and then everything is 80, maybe it is better to differentiate the service port as 80 and container port as 8080
There was a problem hiding this comment.
Yes, we could allow to specify the target port in the values file too.
|
not tested yet |
| @@ -30,7 +30,7 @@ spec: | |||
| imagePullPolicy: {{ .Values.server.image.pullPolicy }} | |||
| ports: | |||
| - name: http | |||
| containerPort: {{ .Values.server.service.port }} | |||
| containerPort: {{ .Values.server.runtime_args.settings.server.host_port }} | |||
There was a problem hiding this comment.
I am trying to wrap my head around this one. Did it work because service.port was set to 80 and host port was http in the templates so since everything was 80 it so happened that it was ok?
There was a problem hiding this comment.
Yes, i think it was very lucky because everything was 80
No description provided.