-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change pipeline build stage to use windows-latest #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 98% 98%
=====================================
Files 62 62
Lines 9077 9077
=====================================
Hits 8978 8978
Misses 99 99 |
Are you seeing build fails with latest Sampler? Curious what fails... |
The latest build is failing because i think it's not seeing the schema.mof for one of the x resources |
I created an issue to track it: gaelcolas/Sampler#410 Have you tested that the build fails the same way on Windows too? |
If a better workaround is to move the build stage from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NEllis280)
RequiredModules.psd1
line 16 at r1 (raw file):
ModuleBuilder = 'latest' ChangelogManagement = '2.1.4' Sampler = '0.116.0'
Tested to build locally and Sampler v0.116.1 (the latest version) works on Windows. So I suggest changing the build stage in azure-pipelines.yml to use vm image windows-latest
.
From local build (no errors):
...
Looking for DSC Composite Resources in 'C:\source\ConfigMgrCBDsc\output\ConfigMgrCBDsc\3.1.0\DSCResources'
Adding 'xSCCMInstall, xSCCMPreReqs' to the list of DscResource will be write in module manifest.
...
Code quote:
Sampler = '0.116.0'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @johlju)
RequiredModules.psd1
line 16 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Tested to build locally and Sampler v0.116.1 (the latest version) works on Windows. So I suggest changing the build stage in azure-pipelines.yml to use vm image
windows-latest
.From local build (no errors):
... Looking for DSC Composite Resources in 'C:\source\ConfigMgrCBDsc\output\ConfigMgrCBDsc\3.1.0\DSCResources' Adding 'xSCCMInstall, xSCCMPreReqs' to the list of DscResource will be write in module manifest. ...
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NEllis280)
Restricting version of Sampler to pass build
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is