Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pipeline build stage to use windows-latest #112

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

NEllis280
Copy link
Contributor

@NEllis280 NEllis280 commented Jan 10, 2023

Restricting version of Sampler to pass build

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #112 (09673d7) into master (4a858b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          62     62           
  Lines        9077   9077           
=====================================
  Hits         8978   8978           
  Misses         99     99           

@johlju
Copy link
Member

johlju commented Jan 11, 2023

Are you seeing build fails with latest Sampler? Curious what fails...

@NEllis280
Copy link
Contributor Author

Are you seeing build fails with latest Sampler? Curious what fails...

The latest build is failing because i think it's not seeing the schema.mof for one of the x resources

https://dev.azure.com/dsccommunity/ConfigMgrCBDsc/_build/results?buildId=7330&view=logs&jobId=0293d6db-8469-5a47-abbc-6f6aba61562f&j=0293d6db-8469-5a47-abbc-6f6aba61562f&t=4fff1e01-0f29-59ad-a7ee-7e9cb6dea69b

@johlju
Copy link
Member

johlju commented Jan 11, 2023

I created an issue to track it: gaelcolas/Sampler#410

Have you tested that the build fails the same way on Windows too?

@johlju
Copy link
Member

johlju commented Jan 11, 2023

If a better workaround is to move the build stage from ubuntu 20.04 to build worker windows-latest, but won't do any good if build fails on Windows. There is an issue with MOF resources with ubuntu-latest (ubuntu 22.04) so cold be a good idea to move the build stage to windows-latest regardless.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @NEllis280)


RequiredModules.psd1 line 16 at r1 (raw file):

    ModuleBuilder               = 'latest'
    ChangelogManagement         = '2.1.4'
    Sampler                     = '0.116.0'

Tested to build locally and Sampler v0.116.1 (the latest version) works on Windows. So I suggest changing the build stage in azure-pipelines.yml to use vm image windows-latest.

From local build (no errors):

...
Looking for DSC Composite Resources in 'C:\source\ConfigMgrCBDsc\output\ConfigMgrCBDsc\3.1.0\DSCResources'
  Adding 'xSCCMInstall, xSCCMPreReqs' to the list of DscResource will be write in module manifest.
...

Code quote:

Sampler                     = '0.116.0'

Copy link
Contributor Author

@NEllis280 NEllis280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @johlju)


RequiredModules.psd1 line 16 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Tested to build locally and Sampler v0.116.1 (the latest version) works on Windows. So I suggest changing the build stage in azure-pipelines.yml to use vm image windows-latest.

From local build (no errors):

...
Looking for DSC Composite Resources in 'C:\source\ConfigMgrCBDsc\output\ConfigMgrCBDsc\3.1.0\DSCResources'
  Adding 'xSCCMInstall, xSCCMPreReqs' to the list of DscResource will be write in module manifest.
...

Done.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NEllis280)

@johlju johlju changed the title Sampler module version control Change pipeline build stage to use windows-latest Jan 13, 2023
@johlju johlju changed the title Change pipeline build stage to use windows-latest Change pipeline build stage to use windows-latest Jan 13, 2023
@johlju johlju merged commit c8d211c into master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants