Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, let me say I think you make the best Plasma 5 add-on in the KDE Store 🥇; I'd be crushed if I ever lost the ability to add it to all of my computers.
This PR was born out of my own need to rebuild the deb file available from your PPA against the most recent libqalculate version which I package myself as an enthusiast of the project (available here if you're curious), as a recent release incremented the soname version from libqalculate20 to libqalculate21. In the process of setting up the rebuild I had occasion to flesh out some of your packaging files and orient them towards a more automated workflow, the results of which seemed only fair to share with you in the event you found them useful for your own packaging efforts.
Some notable changes/additions:
That's all that stands out off the top of my head, but of course I'm happy to elaborate on these or any other questions which might arise. Lastly, I had a mind to create a project and a team on Launchpad such that the codebase could be mirrored there in a Bazaar repository which would lend itself most elegantly to a couple source code recipes that would automate building packages for new releases (both of this project and for future Ubuntu releases). How does that idea strike you? If not poorly then would you prefer to create them yourself or shall I? As a joint effort I'd be happy to help out when needed keeping the packaging up-to-date and looking after the recipes, or if you're amenable to the idea but have no interest in being involved that's fine too.
That pretty much wraps it up for me at this point, I hope this PR finds you well and I look forward to your response in due time.
-Peter