Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

cleanup #3

wants to merge 4 commits into from

Conversation

burtbeckwith
Copy link

No description provided.

@dstieglitz
Copy link
Owner

Hi Burt:

Are you able to run the tests from your fork? I am seeing errors that prevent the test from running:

| Error 2015-10-16 07:23:44,004 [main] ERROR spring.BeanBuilder  - WARNING: Your cache provider is set to 'org.grails.ignite.HibernateRegionFactory' in DataSource.groovy, however the class for this provider cannot be found.
| Error 2015-10-16 07:23:48,754 [main] ERROR spring.BeanBuilder  - Error loading beans for resource pattern: ignite/conf/*.groovy
Message: class path resource [ignite/conf/] cannot be resolved to URL because it does not exist

@burtbeckwith
Copy link
Author

No, the test didn't compile because it referenced a non-existent "Widget" domain class. If you push that to master I can try it out and see what's up.

@dstieglitz
Copy link
Owner

Pushed in 07f7b05

On Fri, Oct 16, 2015 at 10:11 AM, Burt Beckwith notifications@github.com
wrote:

No, the test didn't compile because it referenced a non-existent "Widget"
domain class. If you push that to master I can try it out and see what's up.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Conflicts:
	test/integration/org/grails/ignite/ConfigurationIntegrationSpec.groovy
@burtbeckwith
Copy link
Author

With that domain class the tests start, but fail for several reasons.

One error is that the ignite/conf classes aren't found in the classpath, which makes sense because Grails does nothing with unknown additional root directories. Manually moving those under src/groovy got past that.

But then there's this message WARNING: Your cache provider is set to 'org.grails.ignite.HibernateRegionFactory' in DataSource.groovy, however the class for this provider cannot be found and java.lang.ClassNotFoundException: org.grails.ignite.HibernateRegionFactory. The compiled class exists in target/classes so I'm not sure why that's failing.

I see the same behavior in master and my fork.

@dstieglitz
Copy link
Owner

If I do a clean clone of master and test-app, Ignite starts properly and my tests do run (but fail although they fail due to a test condition). I don't see the HibernateRegionFactory error.

Note that I didn't need to move the configuration files for that to work either. In our production app we use a /etc/app/conf.d style mechanism for configuring our grails app so this plugin was meant to be compatible with that scheme.

I do see that behavior in your fork. I have experienced class loading issues while developing this plugin, although writing a wrapper class in src/groovy usually solved the problem (see IgniteGrailsLogger.java for example)

@dstieglitz
Copy link
Owner

Hi @burtbeckwith:

I created a very basic grails test application for this plugin: https://github.com/dstieglitz/grails-ignite-testapp

I'm curious to know if you are able to run this plugin as configured?

Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants