Generalize some aspects of the blossom test suite #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpeterson
reviewed
Nov 10, 2023
|
|
||
| (defmethod normalize-match ((id-a anatevka-tests::grid-location) | ||
| (id-b anatevka-tests::grid-location) | ||
| &key offset) |
There was a problem hiding this comment.
Small comment that it’s illegal for this not to be supplied. Either it should have a good default (eg, ‘(0 0), which you can replace in other method definitions for other types of id) or you should supply a default of (error “missing offset”) if you want the user to name it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it can be re-used and extended.