Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include target-root in the got-recommendation log entry #53

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Include target-root in the got-recommendation log entry #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06177c6
Include target-root in the got-recommendation log entry
karalekas Dec 4, 2023
932d2db
Also fix an error in a comment in reweight.lisp
karalekas Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/operations/reweight.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
;; the contents of `targets' depend on the recommendation. it always
;; includes the `source-root', and additionally
;; - `AUGMENT': the `target-root'
;; - `GRAFT': the barbell
;; - `GRAFT': one end of the barbell
;; - `EXPAND' or `CONTRACT': nothing
(let ((targets (remove-duplicates (list source-root target-root)
:test #'address=)))
Expand Down
1 change: 1 addition & 0 deletions src/supervisor.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ PONG: The PONG that this process received at its START."
(with-slots (edges weight source-root target-root recommendation) pong
(log-entry :entry-type 'got-recommendation
:source-root source-root
:target-root target-root
:recommendation recommendation
:weight weight
:edges edges)
Expand Down