Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ensure release job blocks PRs, fix broken markdown format #1002

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

twentylemon
Copy link
Member

@twentylemon twentylemon commented Nov 12, 2024

Summary

#1001 for some reason auto-merged despite the test check failing. release is the only check that is required for branch protections, and it was skipped because test failed, which apparently counts as succeeding. Docs say use the always() conditional expression in addition to needsuse the always() conditional expression in addition to needs, but that isn't exactly useful either since we want release to just be a marker. Chaining always() with failure() should work? Draft for testing it out. contains works better, actions link to failure.

This also fixes the broken format.

Checklist
  • this is a source code change
    • run format in the repository root
    • run pytest in the repository root
    • link to issue being fixed using a fixes keyword, if such an issue exists
    • update the wiki documentation if necessary
  • or, this is not a source code change

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (cec7517) to head (910519a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          94       94           
  Lines        2206     2206           
  Branches      160      160           
=======================================
  Hits         2128     2128           
  Misses         67       67           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twentylemon twentylemon marked this pull request as ready for review November 12, 2024 15:03
This reverts commit 51ea4c0.
@twentylemon twentylemon enabled auto-merge (squash) November 12, 2024 15:03
@twentylemon twentylemon changed the title 🐛 ensure release job blocks PRs 🐛 ensure release job blocks PRs, fix broken markdown format Nov 12, 2024
@twentylemon twentylemon merged commit f7a8edd into duck-dynasty:main Nov 13, 2024
10 checks passed
@twentylemon twentylemon deleted the fmt branch November 13, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants