Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 move _generate_next_value_ function to comply with python3.11 #1005

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

twentylemon
Copy link
Member

Summary

Setting up new Chromebook, I can't seem to get python3.10 on it. Running tests with 3.11, I get,

E TypeError: generate_next_value must be defined before members

so moving those around to comply.

Checklist
  • this is a source code change
    • run format in the repository root
    • run pytest in the repository root
    • link to issue being fixed using a fixes keyword, if such an issue exists
    • update the wiki documentation if necessary
  • or, this is not a source code change

@twentylemon twentylemon enabled auto-merge (squash) November 18, 2024 00:52
Copy link
Collaborator

@jameshughes89 jameshughes89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.51%. Comparing base (ba29814) to head (29a5493).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
duckbot/cogs/games/satisfy/building.py 50.00% 1 Missing ⚠️
duckbot/cogs/games/satisfy/item.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1005   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          95       95           
  Lines        2237     2237           
  Branches      165      165           
=======================================
  Hits         2159     2159           
  Misses         67       67           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twentylemon twentylemon merged commit ba5f2ea into duck-dynasty:main Nov 18, 2024
10 of 11 checks passed
@twentylemon twentylemon deleted the enum-3.11 branch November 18, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants