🐛 send multiple messages if solution is too big #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 96.51% 96.53% +0.02%
==========================================
Files 95 95
Lines 2237 2251 +14
Branches 165 168 +3
==========================================
+ Hits 2159 2173 +14
Misses 67 67
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| else: | ||
| total = 0 | ||
| groups.append(group) | ||
| return groups + [group] if group else groups |
There was a problem hiding this comment.
I imagine there's a functional way to do this, but I can't think of it right now.
| return Embed(title="a" * length) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("length", [0, 1, 3000, 6001]) |
There was a problem hiding this comment.
are 3000 and 6001 meaningful?
There was a problem hiding this comment.
There was a problem hiding this comment.
6000 is the max embed length discord has. 3000 is just a non-1 number within the size limit
jameshughes89
approved these changes
Nov 20, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #959
Discord has a message size limit, which sometimes big solutions will run into. This chunks up the message into the biggest possible components that can fit into a single message, then send multiple messages.
Checklist
formatin the repository rootpytestin the repository root