Fix CentOS7 going EOL #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, can we merge it so I can update my repos to use it, so CI can go green? |
|
Can we also get it pushed into the v1.0.0 branch? |
|
@rustyconover I realized there was some other issue so i wanted to test things out first. But I guess since things are already broken I might as well merge into v1 now. Done! |
|
thank you! |
|
Note that the 26% figure includes EOL python versions (eg python2), and this drops to 10% for non-EOL python versions |
|
@JAicewizard that's correct, but since we also use the manylinux2014 for our linux duckdb cli builds, i'm not sure we are ready to exclude these people from using our binaries just yet. We will keep an eye on the numbers and at some point decide to bid manylinux2014 farewell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7 is hilariously old, but according to https://mayeut.github.io/manylinux-timeline we are not ready to give up just yet: ~26% of people are not yet on GLIBC 2.28 (which would be the next step up in manylinux-land). So for now we bandaid our manylinux builds. The fix here appears to do the trick, but I will keep an eye on pypa/manylinux#1641 where a different/better solution might get proposed