Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-211: Add support for is_private in upload_csv #98

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

hawkaa
Copy link
Contributor

@hawkaa hawkaa commented Oct 6, 2023

As per duneanalytics/docs#399 , the Dune Upload API now supports uploading private datasets. With this commit, we add this functionality to the upload_csv function.

I recognize that this functionality gets inside the "Plus Subscription" section even though it is premium. I decided that this was the best option and cleaner than creating a upload_csv_private function.

Closes #97.

@hawkaa hawkaa requested review from msf and bh2smith October 6, 2023 13:13
As per duneanalytics/docs#399 , the Dune Upload
API now supports uploading private datasets. With this commit, we add
this functionality to the upload_csv function.

I recognize that this functionality gets inside the "Plus Subscription"
section even though it is premium. I decided that this was the best
option and cleaner than creating a `upload_csv_private` function.

Closes #97.
Copy link
Collaborator

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hawkaa hawkaa merged commit a769b48 into main Oct 7, 2023
3 checks passed
@hawkaa hawkaa deleted the hakon/private branch October 7, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for private CSV uploads
2 participants