Skip to content

Commit

Permalink
Remove unused token
Browse files Browse the repository at this point in the history
  • Loading branch information
a-monteiro committed Jun 20, 2024
1 parent 0656a1d commit 636a568
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: "Build Docker image and push to Dockerhub"
runs-on: ubuntu-latest
env:
AWS_REGION: us-east-1
AWS_REGION: us-east-1 # This is the region to authenticate against for public ECR repositories
# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
Expand All @@ -36,8 +36,5 @@ jobs:
sudo apt-get update
sudo apt-get install -y qemu-user-static
- env:
GITHUB_TOKEN: ${{ secrets.DUNE_ENG_ACCESS_TOKEN }}
DOCKER_HUB_KEY: ${{ secrets.DOCKER_HUB_KEY }}
run: |
- run: |
make image-push
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ gen-mocks: bin/moq ./client/jsonrpc/ ./client/duneapi/

image-build:
@echo "# Building Docker images"
docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v8 -t public.ecr.aws/duneanalytics/node-indexer:latest -f Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} .
docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v8 -t public.ecr.aws/duneanalytics/node-indexer:latest -f Dockerfile .

image-push:
@echo "# Pushing Docker images to ECR (after building)"
docker buildx create --name mybuilder
docker buildx use mybuilder
docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v8 -t public.ecr.aws/duneanalytics/node-indexer:latest -f Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} --push .
docker buildx build --platform linux/amd64,linux/arm64,linux/arm/v8 -t public.ecr.aws/duneanalytics/node-indexer:latest -f Dockerfile --push .

0 comments on commit 636a568

Please sign in to comment.