Add Get and Post for ProgressReport #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vegarsti
commented
Jun 11, 2024
vegarsti
force-pushed
the
progress-report
branch
from
e9c1c40 to
e3cd9d3
Compare
msf
reviewed
Jun 11, 2024
vegarsti
force-pushed
the
progress-report
branch
3 times, most recently
from
6fc3ab3 to
d28f60a
Compare
vegarsti
force-pushed
the
progress-report
branch
from
d28f60a to
bf48eec
Compare
|
The failing test is a bit flaky, there's a race condition (we don't change it here). The next PR is more stable, we change the main ingester logic a bit there. |
helanto
approved these changes
Jun 12, 2024
| } | ||
| err = fmt.Errorf("got non-OK response, status code: %d, body: '%s'", resp.StatusCode, errorResp.Error) | ||
| // No progress yet | ||
| if resp.StatusCode == http.StatusNotFound { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Get and Post methods for the progress report API (https://github.com/duneanalytics/duneapi/pull/559).
We use the endpoints in #17 (and they work!).
Towards CHAIN-1588.