Dune client: SendBlock -> SendBlocks #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 25, 2024
Closed
msf
approved these changes
Jun 26, 2024
| if err != nil { | ||
| return request, err | ||
| return nil, err |
Oh I see! That makes sense. I'll change it so we read the body as a string without parsing anything |
vegarsti
force-pushed
the
dune-client-batch-blocks
branch
from
3c2104d to
75cb211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Dune client to send a batch of blocks. We still only send one block from the main loop, though.
See also previous draft PR #36.