Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option: max-batch-size #68

Merged
merged 1 commit into from
Jul 25, 2024
Merged

add config option: max-batch-size #68

merged 1 commit into from
Jul 25, 2024

Conversation

msf
Copy link
Contributor

@msf msf commented Jul 24, 2024

allow cmdline configuration of max batch size on DuneAPI request.

This is useful to test different batch sizes, their throughput and error rates.

For example: large batches increase throughput but have higher latency and can lead to request timeouts.

allow cmdline configuration of max batch size on DuneAPI request.

This is useful to test different batch sizes, their throughput and error rates.

For example: large batches increase throughput but have higher latency
and can lead to request timeouts.
@msf msf requested review from adammilnesmith and helanto July 24, 2024 00:18
Copy link
Contributor

@helanto helanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ingester/ingester.go Show resolved Hide resolved
config/config.go Show resolved Hide resolved
@msf msf merged commit edc19bf into main Jul 25, 2024
1 check passed
@msf msf deleted the configurable-max-batch-size branch July 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants