Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to specify a note when reporting phishing emails #24

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

kiwiz
Copy link

@kiwiz kiwiz commented Aug 28, 2017

This change only covers necessary frontend changes - the dashboard stills needs to be updated to support this. See #21.

There are some other changes in this PR that may be contentious:

  • Enabled IsThisLegit on inbox.google.com
    • Updated button (to a hook icon) so it shows up better in Inbox

This change only covers necessary frontend changes - the dashboard
stills needs to be updated to support this.
@jordan-wright
Copy link
Contributor

This looks fantastic! Thanks for sending this over. I'll review this later this week and, if all looks good, will merge it into a branch. That way, I can work on the dashboard side of things to at least get the notes stored properly before merging into master.

Thanks again for sending this over! Great stuff!

@jordan-wright jordan-wright changed the base branch from master to 21-add-notes August 28, 2017 17:21
@jordan-wright
Copy link
Contributor

I'm going to go ahead and merge this into the 21-add-notes branch so I can start work on the backend stuff. I know the dashboard can be a bit less-clean to navigate, so when I have the work complete I'll tag you in case you're interested to see the process of adding stuff to the dashboard.

In terms of what this will look like for admins, I'm likely going to add comment boxes (very similar to those seen here in the Github issues) directly into the event timeline.

@jordan-wright jordan-wright merged commit 0cade45 into duo-labs:21-add-notes Aug 28, 2017
@kiwiz
Copy link
Author

kiwiz commented Aug 29, 2017

✌️ Sgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants