[PR] Exporting default types properly so it matches the javascript file. #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #411
The problem was related to how the
default export
was being treated from Typescript to Javascript. They didn't match, so what happened is that, after transpiling the Typescript to Javascript, thejs
files would have a different way of exporting the defaultAWS
variable than what was described in the Typescript files. Read https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/FalseExportDefault.md for a comprehensive overview.This PR fixes this and changes the way
AWS
is exported toexport = AWS
(instead ofexport default AWS
).In addition to this, the bundle configuration from
tsup
is now explicit.