Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over inline descriptions for labels to new repos #84

Closed
iteles opened this issue Mar 18, 2018 · 6 comments
Closed

Copy over inline descriptions for labels to new repos #84

iteles opened this issue Mar 18, 2018 · 6 comments
Assignees
Labels
help wanted If you can help make progress with this issue, please comment! priority-4 Deprioritised until all other higher priority items are complete.

Comments

@iteles
Copy link
Member

iteles commented Mar 18, 2018

Following on from #82, as an org admin,
I would like label-sync to not only copy over labels to my new repo, but also the inline descriptions,
So that there is no need to refer to the readme in the dwyl/labels repo to better understand them.

@iteles iteles added help wanted If you can help make progress with this issue, please comment! priority-4 Deprioritised until all other higher priority items are complete. labels Mar 18, 2018
@ArsalaBangash
Copy link

I haven't tested it out because I haven't had the time to setup the repo locally, but I suspect this could be addressed by adding the description field to line 33 of lib/copy.js

body: { name: label.name, color: label.color, description: label.description }

I verified that the field in the API is called description:

image

@ArsalaBangash
Copy link

@iteles Hi! Do you have any updates on this? This tool is pretty useful to me and my students, and I'd like to be able to copy over descriptions with it.

@nelsonic
Copy link
Member

@ArsalaBangash thank you for showing and interest in this feature for the label sync tool
and for sharing that you and your students find it useful! 🎉

As with all Open Source, contributions are always welcome, hence the help-wanted label on this issue. 💡

@iteles I have made the required code change in PR #93

I added descriptions to all the labels in this repo: https://github.com/dwyl/labels/labels (please change as needed)
image

And then used the working App on my localhost to sync the labels to on of my personal repos:
label-sync-success-localhost

https://github.com/nelsonic/learn-music/labels

Before:
nelsonic-learn-music-before-sync

After:
nelsonic-learn-music-after-sync-with-label-descriptions

I don't have access to the Heroku App, see: #77 so I cannot test the update on Heroku.
Assigning this issue to you as I feel we can safely merge the PR without it breaking the Heroku App.

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Jul 31, 2020
@iteles iteles closed this as completed in 46a1225 Jul 31, 2020
iteles added a commit that referenced this issue Jul 31, 2020
@nelsonic nelsonic removed the awaiting-review An issue or pull request that needs to be reviewed label Jul 31, 2020
@nelsonic
Copy link
Member

nelsonic commented Aug 1, 2020

This feature is merged into master as part of #93
but has not yet been deployed as per #95 (build failed due to Node.js not being specified in package.json...)
I'm working on #95 now and will get the label.description deployed ASAP. ⏳

@nelsonic
Copy link
Member

nelsonic commented Aug 1, 2020

New version of app that copies label.description deployed. 🚀
Now using: https://label-sync.herokuapp.com
image

We can update the labels on a random throwaway project, e.g: https://github.com/nelsonic/rumbl/labels

BEFORE:
image

AFTER:
image

@ArsalaBangash hope you and your team enjoy using the new version. 🙌

@ArsalaBangash
Copy link

Hi @nelsonic I thought of following up on this, and was very pleased to see that you guys merged this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted If you can help make progress with this issue, please comment! priority-4 Deprioritised until all other higher priority items are complete.
Projects
None yet
Development

No branches or pull requests

3 participants