Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests Failing (due to breaking change in shot dependency) #92

Closed
nelsonic opened this issue Jul 31, 2020 · 1 comment
Closed

Tests Failing (due to breaking change in shot dependency) #92

nelsonic opened this issue Jul 31, 2020 · 1 comment
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment!

Comments

@nelsonic
Copy link
Member

While making the code update for #84 I noted that the tests fail. 😞
Sadly, there is a breaking change in hapi > shot which breaks our tests:

image

> labels@1.0.0 test /Users/n/code/labels
> tape ./test/*.test.js

(node:33195) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
TAP version 13
# github_oauth_handler : no profile
ok 1 get redirected to login if no profile given back
# github_oauth_handler : profile
ok 2 get redirected to login if no profile given back
ok 3 session signed ok
# / : not logged in : no session
(node:33195) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
Visit: http://localhost:4000/
Debug: internal, implementation, error
    TypeError: Cannot read property 'length' of undefined
    at Object.internals.payload (/Users/n/code/labels/node_modules/hapi/node_modules/shot/lib/response.js:91:41)
    at module.exports.internals.Response.<anonymous> (/Users/n/code/labels/node_modules/hapi/node_modules/shot/lib/response.js:19:31)
    at Object.onceWrapper (events.js:421:28)
    at module.exports.internals.Response.emit (events.js:327:22)
    at module.exports.internals.Response.EventEmitter.emit (domain.js:483:12)
    at module.exports.internals.Response.internals.Response.end (/Users/n/code/labels/node_modules/hapi/node_modules/shot/lib/response.js:64:10)
    at internals.Response.Payload.internals.Payload.onend (_stream_readable.js:681:10)
    at Object.onceWrapper (events.js:421:28)
    at internals.Response.Payload.internals.Payload.emit (events.js:315:20)
    at internals.Response.Payload.internals.Payload.EventEmitter.emit (domain.js:506:15)

Node Version: v12.18.3

I don't have the appetite to debug the shot library included in hapi for testing.
If anyone else wants to help with this "maintenance chore", please go for it!

I'd much sooner re-build the Labels project in Phoenix as a test/showcase for Auth + auth_plug.

@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt labels Jul 31, 2020
@nelsonic nelsonic changed the title Tests Failing (due to broken dependency) Tests Failing (due to breaking change in shot dependency) Aug 1, 2020
@SimonLab
Copy link
Member

SimonLab commented Jul 7, 2022

The application is now using Phoenix, see #104

@SimonLab SimonLab closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment!
Projects
None yet
Development

No branches or pull requests

2 participants