Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node version 4.1.1 to package.json #96

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Add Node version 4.1.1 to package.json #96

merged 1 commit into from
Aug 1, 2020

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Aug 1, 2020

As discussed in: #95 (comment)
I've added a couple of lines to package.json to keep Heroku happy (for now...)

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Aug 1, 2020
@nelsonic nelsonic requested a review from iteles August 1, 2020 18:01
@nelsonic
Copy link
Member Author

nelsonic commented Aug 1, 2020

New version of app that copies label.description deployed. 🚀
Now using: https://label-sync.herokuapp.com
image

We can update the labels on a random throwaway project, e.g: https://github.com/nelsonic/rumbl/labels

BEFORE:
image

*AFTER:
image

@nelsonic
Copy link
Member Author

nelsonic commented Aug 1, 2020

Again the build will fail because of #92 ... 🙄

I'm definitely considering porting this to Phoenix.
Hapi is not what it used to be ... dwyl/start-here#77 (comment)
It's all about the Benjamins ... 💵
The creator/owner wants to extract as much consulting income from supporting big companies using the framework so answers are on Slack instead of being open and indexed.

@nelsonic nelsonic mentioned this pull request Aug 1, 2020
Closed
@iteles iteles added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Aug 1, 2020
iteles
iteles approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@iteles iteles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonic Thanks for the change and the comprehensive testing and screenshots. 👍🏻

@iteles
Copy link
Member

iteles commented Aug 1, 2020

As you mentioned, merging despite Travis CI’s build failing as the reasons for this are captured in #92

@iteles iteles merged commit 03579b5 into master Aug 1, 2020
@iteles iteles deleted the add-node-version-to-packagejson-issue-95 branch August 1, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Assignees

@iteles iteles

Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @iteles