Remove unimplemented indexer endpoint of get subaccount funding

dydxprotocol · Sep 20, 2023 · 5a1c158 · 5a1c158
1 parent 6eceb6c
commit 5a1c158
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 90 deletions.
diff --git a/v4-client-js/__tests__/modules/client/AccountEndpoints.test.ts b/v4-client-js/__tests__/modules/client/AccountEndpoints.test.ts
@@ -78,20 +78,6 @@ describe('IndexerClient', () => {
       }
     });
 
-    /*
-    ** Funding endpoint is not implemented in the indexer yet
-    it('Funding', async () => {
-      const response = await client.account.getSubaccountFunding(DYDX_TEST_ADDRESS, 0);
-      expect(response).not.toBeNull();
-      const funding = response.funding;
-      expect(funding).not.toBeNull();
-      if (funding.length > 0) {
-        const funding0 = funding[0];
-        expect(funding0).not.toBeNull();
-      }
-    });
-    */
-
     it('Historical PNL', async () => {
       const response = await client.account.getSubaccountHistoricalPNLs(DYDX_TEST_ADDRESS, 0);
       expect(response).not.toBeNull();

diff --git a/v4-client-js/examples/account_endpoints.ts b/v4-client-js/examples/account_endpoints.ts
@@ -107,20 +107,6 @@ async function test(): Promise<void> {
     console.log(error.message);
   }
 
-  // Get funding payments
-  try {
-    const response = await client.account.getSubaccountFunding(address, 0);
-    console.log(response);
-    const fundingPayments = response.fundingPayments;
-    console.log(fundingPayments);
-    if (fundingPayments.length > 0) {
-      const fundingPayments0 = fundingPayments[0];
-      console.log(fundingPayments0);
-    }
-  } catch (error) {
-    console.log(error.message);
-  }
-
   // Get historical pnl
   try {
     const response = await client.account.getSubaccountHistoricalPNLs(address, 0);

diff --git a/v4-client-js/package-lock.json b/v4-client-js/package-lock.json
diff --git a/v4-client-js/src/clients/modules/account.ts b/v4-client-js/src/clients/modules/account.ts
@@ -134,23 +134,6 @@ export default class AccountClient extends RestClient {
     });
   }
 
-  async getSubaccountFunding(
-    address: string,
-    subaccountNumber: number,
-    limit?: number | null,
-    createdBeforeOrAtHeight?: number | null,
-    createdBeforeOrAt?: string | null,
-  ): Promise<Data> {
-    const uri = '/v4/funding';
-    return this.get(uri, {
-      address,
-      subaccountNumber,
-      limit,
-      createdBeforeOrAtHeight,
-      createdBeforeOrAt,
-    });
-  }
-
   async getSubaccountHistoricalPNLs(
     address: string,
     subaccountNumber: number,

diff --git a/v4-client-py/v4_client_py/clients/modules/account.py b/v4-client-py/v4_client_py/clients/modules/account.py
@@ -384,48 +384,6 @@ def get_subaccount_fills(
             },
         )
 
-    def get_subaccount_funding(
-        self,
-        address: str,
-        subaccount_number: int,
-        limit: int = None,
-        created_before_or_at_height: int = None,
-        created_before_or_at_time: str = None,
-    ) -> Response:
-        '''
-        Get asset transfers record
-
-        :param address: required
-        :type address: str
-
-        :param subaccount_number: required
-        :type subaccount_number: int
-
-        :param limit: optional
-        :type limit: number
-
-        :param created_before_or_at_height: optional
-        :type created_before_or_at_height: number
-
-        :param created_before_or_at_time: optional
-        :type created_before_or_at_time: ISO str
-
-        :returns: Array of funding payments
-
-        :raises: DydxAPIError
-        '''
-        return self._get(
-            '/v4/funding',
-            {
-                'address': address,
-                'subaccountNumber': subaccount_number,
-                'limit': limit,
-                'createdBeforeOrAtHeight': created_before_or_at_height,
-                'createdBeforeOrAt': created_before_or_at_time,
-            },
-        )
-
-
     def get_subaccount_historical_pnls(
         self,
         address: str,
@@ -460,4 +418,4 @@ def get_subaccount_historical_pnls(
                 'effectiveBeforeOrAt': effective_before_or_at,
                 'effectiveAtOrAfter': effective_at_or_after,
             },
-        )
+        )