Adding createdBeforeOrAt param to getTrades API (#184)

Adds the `createdBeforeOrAt` param to the JS client's GetTrades function.
dydxprotocol · Jul 1, 2024 · 5ae6549 · 5ae6549
1 parent 1f8ad15
commit 5ae6549
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/v4-client-js/__native__/__ios__/v4-native-client.js b/v4-client-js/__native__/__ios__/v4-native-client.js
@@ -206700,10 +206700,11 @@ class MarketsClient extends rest_1.default {
         const uri = `/v4/orderbooks/perpetualMarket/${market}`;
         return this.get(uri);
     }
-    async getPerpetualMarketTrades(market, startingBeforeOrAtHeight, limit, page) {
+    async getPerpetualMarketTrades(market, startingBeforeOrAtHeight, startingBeforeOrAt, limit, page) {
         const uri = `/v4/trades/perpetualMarket/${market}`;
         return this.get(uri, {
             createdBeforeOrAtHeight: startingBeforeOrAtHeight,
+            createdBeforeOrAt: startingBeforeOrAt,
             limit,
             page,
         });
@@ -206733,7 +206734,7 @@ class MarketsClient extends rest_1.default {
     }
 }
 exports["default"] = MarketsClient;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoibWFya2V0cy5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uLy4uLy4uL3NyYy9jbGllbnRzL21vZHVsZXMvbWFya2V0cy50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiOzs7OztBQUFBLDRDQUEwQztBQUUxQyxrREFBZ0M7QUFFaEM7O0dBRUc7QUFDSCxNQUFxQixhQUFjLFNBQVEsY0FBVTtJQUNuRCxLQUFLLENBQUMsbUJBQW1CLENBQUMsTUFBZTtRQUN2QyxNQUFNLEdBQUcsR0FBRyxzQkFBc0IsQ0FBQztRQUNuQyxPQUFPLElBQUksQ0FBQyxHQUFHLENBQUMsR0FBRyxFQUFFLEVBQUUsTUFBTSxFQUFFLE1BQU0sRUFBRSxDQUFDLENBQUM7SUFDM0MsQ0FBQztJQUVELEtBQUssQ0FBQywyQkFBMkIsQ0FBQyxNQUFjO1FBQzlDLE1BQU0sR0FBRyxHQUFHLGtDQUFrQyxNQUFNLEVBQUUsQ0FBQztRQUN2RCxPQUFPLElBQUksQ0FBQyxHQUFHLENBQUMsR0FBRyxDQUFDLENBQUM7SUFDdkIsQ0FBQztJQUVELEtBQUssQ0FBQyx3QkFBd0IsQ0FDNUIsTUFBYyxFQUNkLHdCQUF3QyxFQUN4QyxLQUFxQixFQUNyQixJQUFvQjtRQUVwQixNQUFNLEdBQUcsR0FBRyw4QkFBOEIsTUFBTSxFQUFFLENBQUM7UUFDbkQsT0FBTyxJQUFJLENBQUMsR0FBRyxDQUFDLEdBQUcsRUFBRTtZQUNuQix1QkFBdUIsRUFBRSx3QkFBd0I7WUFDakQsS0FBSztZQUNMLElBQUk7U0FDTCxDQUFDLENBQUM7SUFDTCxDQUFDO0lBRUQsS0FBSyxDQUFDLHlCQUF5QixDQUM3QixNQUFjLEVBQ2QsVUFBa0IsRUFDbEIsT0FBdUIsRUFDdkIsS0FBcUIsRUFDckIsS0FBcUI7UUFFckIsTUFBTSxHQUFHLEdBQUcsZ0NBQWdDLE1BQU0sRUFBRSxDQUFDO1FBQ3JELE9BQU8sSUFBSSxDQUFDLEdBQUcsQ0FBQyxHQUFHLEVBQUU7WUFDbkIsVUFBVTtZQUNWLE9BQU87WUFDUCxLQUFLO1lBQ0wsS0FBSztTQUNOLENBQUMsQ0FBQztJQUNMLENBQUM7SUFFRCxLQUFLLENBQUMsbUNBQW1DLENBQ3ZDLE1BQWMsRUFDZCxtQkFBbUMsRUFDbkMseUJBQXlDLEVBQ3pDLEtBQXFCO1FBRXJCLE1BQU0sR0FBRyxHQUFHLHlCQUF5QixNQUFNLEVBQUUsQ0FBQztRQUM5QyxPQUFPLElBQUksQ0FBQyxHQUFHLENBQUMsR0FBRyxFQUFFO1lBQ25CLG1CQUFtQjtZQUNuQix5QkFBeUI7WUFDekIsS0FBSztTQUNOLENBQUMsQ0FBQztJQUNMLENBQUM7SUFFRCxLQUFLLENBQUMsNEJBQTRCLENBQUMsU0FBaUIsc0JBQVUsQ0FBQyxPQUFPO1FBQ3BFLE1BQU0sR0FBRyxHQUFHLGdCQUFnQixDQUFDO1FBQzdCLE9BQU8sSUFBSSxDQUFDLEdBQUcsQ0FBQyxHQUFHLEVBQUU7WUFDbkIsVUFBVSxFQUFFLE1BQU07U0FDbkIsQ0FBQyxDQUFDO0lBQ0wsQ0FBQztDQUNGO0FBN0RELGdDQTZEQyJ9
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoibWFya2V0cy5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uLy4uLy4uL3NyYy9jbGllbnRzL21vZHVsZXMvbWFya2V0cy50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiOzs7OztBQUFBLDRDQUEwQztBQUUxQyxrREFBZ0M7QUFFaEM7O0dBRUc7QUFDSCxNQUFxQixhQUFjLFNBQVEsY0FBVTtJQUNuRCxLQUFLLENBQUMsbUJBQW1CLENBQUMsTUFBZTtRQUN2QyxNQUFNLEdBQUcsR0FBRyxzQkFBc0IsQ0FBQztRQUNuQyxPQUFPLElBQUksQ0FBQyxHQUFHLENBQUMsR0FBRyxFQUFFLEVBQUUsTUFBTSxFQUFFLE1BQU0sRUFBRSxDQUFDLENBQUM7SUFDM0MsQ0FBQztJQUVELEtBQUssQ0FBQywyQkFBMkIsQ0FBQyxNQUFjO1FBQzlDLE1BQU0sR0FBRyxHQUFHLGtDQUFrQyxNQUFNLEVBQUUsQ0FBQztRQUN2RCxPQUFPLElBQUksQ0FBQyxHQUFHLENBQUMsR0FBRyxDQUFDLENBQUM7SUFDdkIsQ0FBQztJQUVELEtBQUssQ0FBQyx3QkFBd0IsQ0FDNUIsTUFBYyxFQUNkLHdCQUF3QyxFQUN4QyxrQkFBa0MsRUFDbEMsS0FBcUIsRUFDckIsSUFBb0I7UUFFcEIsTUFBTSxHQUFHLEdBQUcsOEJBQThCLE1BQU0sRUFBRSxDQUFDO1FBQ25ELE9BQU8sSUFBSSxDQUFDLEdBQUcsQ0FBQyxHQUFHLEVBQUU7WUFDbkIsdUJBQXVCLEVBQUUsd0JBQXdCO1lBQ2pELGlCQUFpQixFQUFFLGtCQUFrQjtZQUNyQyxLQUFLO1lBQ0wsSUFBSTtTQUNMLENBQUMsQ0FBQztJQUNMLENBQUM7SUFFRCxLQUFLLENBQUMseUJBQXlCLENBQzdCLE1BQWMsRUFDZCxVQUFrQixFQUNsQixPQUF1QixFQUN2QixLQUFxQixFQUNyQixLQUFxQjtRQUVyQixNQUFNLEdBQUcsR0FBRyxnQ0FBZ0MsTUFBTSxFQUFFLENBQUM7UUFDckQsT0FBTyxJQUFJLENBQUMsR0FBRyxDQUFDLEdBQUcsRUFBRTtZQUNuQixVQUFVO1lBQ1YsT0FBTztZQUNQLEtBQUs7WUFDTCxLQUFLO1NBQ04sQ0FBQyxDQUFDO0lBQ0wsQ0FBQztJQUVELEtBQUssQ0FBQyxtQ0FBbUMsQ0FDdkMsTUFBYyxFQUNkLG1CQUFtQyxFQUNuQyx5QkFBeUMsRUFDekMsS0FBcUI7UUFFckIsTUFBTSxHQUFHLEdBQUcseUJBQXlCLE1BQU0sRUFBRSxDQUFDO1FBQzlDLE9BQU8sSUFBSSxDQUFDLEdBQUcsQ0FBQyxHQUFHLEVBQUU7WUFDbkIsbUJBQW1CO1lBQ25CLHlCQUF5QjtZQUN6QixLQUFLO1NBQ04sQ0FBQyxDQUFDO0lBQ0wsQ0FBQztJQUVELEtBQUssQ0FBQyw0QkFBNEIsQ0FBQyxTQUFpQixzQkFBVSxDQUFDLE9BQU87UUFDcEUsTUFBTSxHQUFHLEdBQUcsZ0JBQWdCLENBQUM7UUFDN0IsT0FBTyxJQUFJLENBQUMsR0FBRyxDQUFDLEdBQUcsRUFBRTtZQUNuQixVQUFVLEVBQUUsTUFBTTtTQUNuQixDQUFDLENBQUM7SUFDTCxDQUFDO0NBQ0Y7QUEvREQsZ0NBK0RDIn0=
 
 /***/ }),
 

diff --git a/v4-client-js/__tests__/modules/client/MarketsEndpoints.test.ts b/v4-client-js/__tests__/modules/client/MarketsEndpoints.test.ts
@@ -32,6 +32,7 @@ describe('IndexerClient', () => {
       const response = await client.markets.getPerpetualMarketTrades(
         MARKET_BTC_USD,
         undefined,
+        undefined,
         1,
         1,
       );

diff --git a/v4-client-js/package-lock.json b/v4-client-js/package-lock.json
diff --git a/v4-client-js/package.json b/v4-client-js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dydxprotocol/v4-client-js",
-  "version": "1.1.24",
+  "version": "1.1.25",
   "description": "General client library for the new dYdX system (v4 decentralized)",
   "main": "build/src/index.js",
   "scripts": {

diff --git a/v4-client-js/src/clients/modules/markets.ts b/v4-client-js/src/clients/modules/markets.ts
@@ -19,12 +19,14 @@ export default class MarketsClient extends RestClient {
   async getPerpetualMarketTrades(
     market: string,
     startingBeforeOrAtHeight?: number | null,
+    startingBeforeOrAt?: string | null,
     limit?: number | null,
     page?: number | null,
   ): Promise<Data> {
     const uri = `/v4/trades/perpetualMarket/${market}`;
     return this.get(uri, {
       createdBeforeOrAtHeight: startingBeforeOrAtHeight,
+      createdBeforeOrAt: startingBeforeOrAt,
       limit,
       page,
     });